Some modern features in Icon and IconStack#52
Open
a-malykhin wants to merge 3 commits intoandreypopp:masterfrom
a-malykhin:master
Open
Some modern features in Icon and IconStack#52a-malykhin wants to merge 3 commits intoandreypopp:masterfrom a-malykhin:master
a-malykhin wants to merge 3 commits intoandreypopp:masterfrom
a-malykhin:master
Conversation
… classnames package for more shorten manage of React component className. Add defaultProps for all non-required properties.
andreypopp
reviewed
Feb 27, 2017
| "babel-loader": "^5.3.2", | ||
| "babel-plugin-espower": "^1.0.0", | ||
| "babel-runtime": "^5.8.20", | ||
| "classnames": "^2.2.5", |
Owner
There was a problem hiding this comment.
Not sure if it's worth it to introduce a dependency.
Author
There was a problem hiding this comment.
Your lib your rules) I just have added this for more clear code. All modern JS-world built on dependencies.
Owner
There was a problem hiding this comment.
Yeah... just not sure if it's worth fixing what ain't broken :-)
Author
There was a problem hiding this comment.
Ok. Anyway you could use stateless components and const except of let in properties destructuring (this variables are never reassigned).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement Icon and IconStack as stateless presentation component. Add classnames package for more shorten manage of React component className. Add defaultProps for all non-required properties.