"close" spans can now be added in the initial DOM to avoid a FOUC without breaking the plugin behavior#4
Open
pjparra wants to merge 4 commits into
Open
"close" spans can now be added in the initial DOM to avoid a FOUC without breaking the plugin behavior#4pjparra wants to merge 4 commits into
pjparra wants to merge 4 commits into
Conversation
To avoid a FOUC, we can add the "close" span directly into the initial DOM. That caused the plugin not to bind events on these pre-added spans. Now events are bound on all "close" spans, no matter if they were added by the plugin or were already present in the DOM.
As jQuery 1.9 removed the _tabify() method (and seems to have replaced it with _refresh() ?), some rewriting was necesary. While this should still work with jQuery 1.8 (not tested), it sure adds support for jQuery 1.9 and works fine.
Author
|
Hi @andrewwatts I know this repository didn't have much activity lately, but I just added support for jQueryUI 1.9. It should still work with jQueryUI 1.8, but I didn't have the opportunity to test it. If someone tests it with jQueryUI 1.8, please let me know if it works or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid a FOUC, we can add the "close" span directly into the initial DOM.
That caused the plugin not to bind events on these pre-added spans.
Now events are bound on all "close" spans, no matter if they were added by the plugin or were already present in the DOM.