Fix issue where SPNs are skipped if XLSX isn't sorted by PGN#1
Open
timsouth94 wants to merge 1 commit intoandrewdodd:mainfrom
Open
Fix issue where SPNs are skipped if XLSX isn't sorted by PGN#1timsouth94 wants to merge 1 commit intoandrewdodd:mainfrom
timsouth94 wants to merge 1 commit intoandrewdodd:mainfrom
Conversation
…N. If SPNs for a particular PGN were separated by other rows, they would be detected as duplicates and discarded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an issue where SPNs are omitted from the JSON output if XLSX isn't sorted by PGN. If SPNs for a particular PGN were separated by other rows, they would be detected as duplicates and discarded..
Tried running the JSON converter on
J1939DA MAY23.xlsxbut got warning saying that 100's of the SPN's were duplicates.