[fix] issue262 fixing SQL-Hint deleting when clearing script from comments #792
+49
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[fix] issue262 fixing problem w/ removing SQL-Hints w/ comments
Contributor
Author
|
Hi, @andialbrecht! |
andialbrecht
requested changes
Oct 26, 2024
Owner
andialbrecht
left a comment
andialbrecht
left a comment
There was a problem hiding this comment.
@skryzh hey, thanks for the pull request! Looks good so far, I've got just some nitpicks.
[feature] deleting envs from .gitignore, creating test for SQL-Hints
[feature] returning .gitignore to previous version
andialbrecht
approved these changes
Nov 14, 2024
Owner
andialbrecht
left a comment
andialbrecht
left a comment
There was a problem hiding this comment.
LGTM! Thanks and sorry for the delay.... busy times, as usual :-D
Contributor
Author
|
It's ok, same :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#Fixing SQL-Hint deleting when clearing script from comments
#262
What is done:
Before submitting your pull request please have a look at the
following checklist:
pytest)flake8)In addition, please take care to provide a proper description
on what your change does, fixes or achieves when submitting the
pull request.