[wip] Allow long captions#2

Open

andi34 wants to merge 35 commits intomasterfrom

allow_long_captions-prettier

Commits on Sep 4, 2020

Rename framework.createEl to framework.createElement for clarity.

PeterSweetAndSour
authored and
andi34
committed
Rename function argument of a DOM node from 'captionEl' to 'captionElement' to avoid confusion with the boolean option of the same name a few lines below. Also add some extra whitespace to separate…

PeterSweetAndSour
authored and
andi34
committed
Capture the calculated size of the image and set an option for the caption to go under the picture and be able to scroll to see it.

PeterSweetAndSour
authored and
andi34
committed
Move new option to the UI file.

PeterSweetAndSour
authored and
andi34
committed
First pass with something that works. Need to fix z-index on captionElement and arrows and figure out why it is failing on mobile.

PeterSweetAndSour
authored and
andi34
committed
Rename button to be consistent pattern with others. Fix z-index issue so arrows are above expanded caption.

PeterSweetAndSour
authored and
andi34
committed
Fix display/hiding of expand control when switching photos.

PeterSweetAndSour
authored and
andi34
committed
Set data attributes on .pswp__item to carry initial image height and top/bottom gaps so that caption function can be initiated with just the event. Not sure if this is better or just different.

PeterSweetAndSour
authored and
andi34
committed
Rename function to indicate that it is private.

PeterSweetAndSour
authored and
andi34
committed
Save so far now that positioning is correct. Need to fix hiding and showing.

PeterSweetAndSour
authored and
andi34
committed
Somewhat closer. Accounting for scale but only on first load. :-( Caption toggles now. Adding/removing whitespace for clarity.

PeterSweetAndSour
authored and
andi34
committed
Seems to work.

PeterSweetAndSour
authored and
andi34
committed
Stop accidental scroll on close. Add a box at the end of the caption to indicate the end. Make caption text white so people like me can actually read it.

PeterSweetAndSour
authored and
andi34
committed
Polyfill for closest() for IE11

PeterSweetAndSour
authored and
andi34
committed
Various fixes

PeterSweetAndSour
authored and
andi34
committed
Sorted out weirdness with tap behavior. Now preventing closing when tapping on the caption because it is too easy to close accidentally when you thought you were swiping.

PeterSweetAndSour
authored and
andi34
committed
Renaming option name and removing redundant code.

PeterSweetAndSour
authored and
andi34
committed
Drag up on collapsed caption will expand it.

PeterSweetAndSour
authored and
andi34
committed
Swap out two lines of SVG for two dozen lines of CSS to make the expand/collapse arrows without another request to get an image and still have it work on IE11. Now need to get the event to fire whe…

PeterSweetAndSour
authored and
andi34
committed
Back to SVG background images but now Base64 encoded and background size set explicitly so that it will work with IE11.

PeterSweetAndSour
authored and
andi34
committed
Ensure HTML exists for caption control and change title on button when toggling the control.

PeterSweetAndSour
authored and
andi34
committed
Allow left/right buttons to show above expanded caption overlay when viewport is wide enough.

PeterSweetAndSour
authored and
andi34
committed
Now with keyboard control.

PeterSweetAndSour
authored and
andi34
committed
Moving the setting of tabindex and focus on the innerCaptionElement to where the keydown events are handled. Also removing some console output.

PeterSweetAndSour
authored and
andi34
committed
Animate expansion and collapse of caption.

PeterSweetAndSour
authored and
andi34
committed
Get around cross-site security issue by creating a new stylesheet rather than attempting to manipulate an existing one.

PeterSweetAndSour
authored and
andi34
committed
A bit of rearrangement as I discovered that dragging to a new photo on a phone does not call the goTo function so the resetCaption function was not getting called which had some odd results.

PeterSweetAndSour
authored and
andi34
committed
Increase the width of the caption if long captions are selected.

PeterSweetAndSour
authored and
andi34
committed
Added section for caption expand/collapse by vertical swipe/drag.

PeterSweetAndSour
authored and
andi34
committed
Add "FYI" to console notices explaining that two options are overridden when allowLongCaptions is true.

PeterSweetAndSour
authored and
andi34
committed
Remove some console output and updated generated files.

PeterSweetAndSour
authored and
andi34
committed

Commits on Sep 5, 2020

Expand and collapse caption with just the mouse wheel

PeterSweetAndSour
authored and
andi34
committed
Add long caption to index
andi34
committed

Commits on Sep 6, 2020

seems to work
andi34
committed
Increase font size

PeterSweetAndSour
authored and
andi34
committed