Fix/validate update custom rule#50
Closed
kevin-foster-uk wants to merge 11 commits intoandersao:developfrom
Closed
Fix/validate update custom rule#50kevin-foster-uk wants to merge 11 commits intoandersao:developfrom
kevin-foster-uk wants to merge 11 commits intoandersao:developfrom
Conversation
Support laravel 6
Laravel 7.0 support
Prepare for laravel 8 support
Laravel 9 Compability
chantouchsek
approved these changes
Jan 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using custom validation rules AbstractValidator::parserValidationRules() fails because it is expecting all rules to be defined as a string. Laravel Validator allows you to define custom rules as Rule objects. In this case AbstractValidator::parserValidationRules() should pass them through as-is.