🛠️ Impl Collection#7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Purpose
The PR brings the implementation of the core
CollectionAPI.⚙️ Details
Here's the functions implemented:
collection::insert();collection::update();collection::save();collection::remove();collection::scan();The arguments have been changed to borrowed values to avoid copy/clone.
The function's bodies are pretty basic, but some refactoring to allow zero-copy and zero-allocation behaviours were needed, especially concerning indexes traits, for instance regarding the
Index::update()signature:The main change here is the lifetime separation between the old record and the primary key, the reason lies in their provenance in the collection methods, for exemple with the update fn: The primary key is provided to
collection::update()so its lifetime outlives its scope, but the old record is fetched incollection::update()so its lifetime is inferior to the primary key and the new value. This caused a necessary change in theindexKind::StoreKey<'ik, 'pk>to carry both lifetimes and thus, contaminating indexes api.🧪 Testing
For testing purposes a mocked implementation of
MultiStorehas been introduced and allows to: