Upgrade go-amqp to v1.3.0#89
Conversation
Upgraded go-amqp dependency to v1.3.0. The changes since v1.0.1 are mostly added features. Fixed some tests that were failing. The end to end tests still fails on DeviceToCloud tests. This has been failing for a long time already.
|
I ran all the tests and everything passes except the end to end tests for device to cloud: TestEnd2End/mqtt/x509/DeviceToCloud These tests has been failing since at least version v0.7.0. I could receive D2C events in iotservice if using the eventhub instead of relying on the redirect from the iothub. Works: Doesn't work: |
The documentation in go-amqp library states that CorrelationID can be: uint64, UUID, []byte, or string Sending a 16 byte hex string as CorrelationId will return a UUID type.
|
I have investigated the errors in the test cases mentioned above and found that the error lies in IoT Hubs implementation (Azure/go-amqp#358). $ go test -count=1 ./... @amenzhinsky, would it be possible to approve the workflow? |
Upgraded go-amqp dependency to v1.3.0. The changes since v1.0.1 are mostly
added features.
Fixed some tests that were failing. The end to end tests still fails on
DeviceToCloud tests. This has been failing for a long time already.