Add tommy-codegen conformist linter (codegen repair in the chore)#367
Open
friedenberg wants to merge 2 commits into
Open
Add tommy-codegen conformist linter (codegen repair in the chore)#367friedenberg wants to merge 2 commits into
friedenberg wants to merge 2 commits into
Conversation
moxy already formats TOML via tommy (treefmt.nix [formatter.tommy]); this adds the codegen half. A self-gating conformist-tommy-codegen driver (skips when tommy/go are off PATH) is appended to the generated conformist config as [linter.tommy-codegen]: the check command is a no-op `true` (the sandboxed conformistCheck lacks the go toolchain `tommy generate --check` needs; true staleness stays gated by `just generate`), and the repair-command regenerates schema_tommy.go via `tommy generate` so it lands in the `conformist --commit` chore. The driver is referenced by absolute store path so it resolves in both the sandbox and the nix-fmt wrapper without a PATH dependency.
Replace the inline tommyCodegenDriver with tommy.packages.${system}.conformist-tommy-codegen
so the pinned tommy flake input resolves which tommy backs the codegen linter.
The appended [linter.tommy-codegen] still references it by absolute store path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
moxy already formats TOML via tommy (treefmt.nix [formatter.tommy]); this adds
the codegen half. A self-gating conformist-tommy-codegen driver (skips when
tommy/go are off PATH) is appended to the generated conformist config as
[linter.tommy-codegen]: the check command is a no-op
true(the sandboxedconformistCheck lacks the go toolchain
tommy generate --checkneeds; truestaleness stays gated by
just generate), and the repair-command regeneratesschema_tommy.go via
tommy generateso it lands in theconformist --commitchore. The driver is referenced by absolute store path so it resolves in both
the sandbox and the nix-fmt wrapper without a PATH dependency.