feat(terminal): persist font size per terminal tab#98
Open
atacolak wants to merge 1 commit into
Open
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

summary
font_sizeas the default for terminals without an overridefont_sizewhy
currently
ctrl++,ctrl+-, and reset behave globally: changing one terminal changes every live terminal surface. in a split workspace this is surprising because each terminal tab is visually independent and often has different content density needs.this patch stores font-size override state on each terminal tab and applies ghostty font-size actions only to the focused terminal surface.
testing
cargo fmt --checkcargo check -p limux-host-linuxcargo test -p limux-host-linuxcargo test --workspacecargo clippy --workspace --all-targets -- -D warnings./scripts/check.sh