feat: convert branch operations to interactive picker #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sei40kr
changed the title
sei40kr
force-pushed
the
feat/branch-interactive-picker
branch
from
9151434 to
3311023
Compare
Owner
|
I noted that cancelling the picker takes me back to the submenu, while as before it would close the submenu completely. I'd vote cancelling should just close everything. |
- Convert Checkout to use interactive picker with fuzzy search - Convert Delete to use interactive picker - Exclude current branch from picker lists - Add comprehensive test coverage for all picker interactions - CheckoutNewBranch and Spinoff remain as text prompts (branch names, not git revs) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Remove 6 tests that duplicate functionality already covered by unit tests in src/picker.rs and src/ui/picker.rs: - checkout_picker_filter - checkout_picker_navigate - checkout_picker_scroll - delete_picker_filter - delete_picker_navigate - delete_picker_scroll These tests verify basic picker functionality (filtering, navigation, scrolling) which is comprehensively tested at the unit level. The branch integration tests now focus on branch-specific operations: candidate retrieval, cancellation, and actual git command execution. Remove setup_many_branches helper function that was only used by the deleted scroll tests.
Close the submenu when opening the branch picker (checkout/delete) so that cancelling the picker returns to the main view instead of the submenu. This provides a better UX where ESC consistently closes everything rather than requiring multiple ESC presses. Before: Picker -> ESC -> Submenu -> ESC -> Main view After: Picker -> ESC -> Main view
Update editor test names to reflect that branch operations now use the picker instead of prompts: - exit_from_prompt_exits_menu -> exit_from_picker_exits_menu - re_enter_prompt_from_menu -> re_enter_picker_from_menu
Remove snapshot files that are no longer referenced by any tests.
sei40kr
force-pushed
the
feat/branch-interactive-picker
branch
from
3311023 to
5be4fe8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Converts branch checkout and delete operations to use the new interactive picker, providing a better user experience for branch selection.
Changes
Test Plan
Dependencies
Note: This PR depends on #468 being merged first.
🤖 Generated with Claude Code