Improve manual one-page generation#51
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughThis PR updates manual navigation templates, refactors the build script for navigation-aware ordering, adds RFC documentation, and introduces an id field to BlogPosting in the REST tutorial across both English and Japanese manuals. ChangesNavigation Templates and Build System
RFC Documentation
Tutorial BlogPosting Content Updates
Documentation Maintenance and Polish
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bin/merge_md_files.rb`:
- Around line 108-113: The fallback_order method currently uses
source.glob('*.md') and .map(&:basename).map(&:to_s) which only finds top-level
files and strips directory structure; change it to recursively find markdown
files (e.g., source.glob('**/*.md')), preserve each file's path relative to
source (use file.relative_path_from(source).to_s or equivalent) instead of
basename so nested pages are included, and adjust the rejection check to either
compare the basename (File.basename) or the relative path against
SKIP_GENERATED_FILES as appropriate before sorting.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: c3010bd7-b7a4-4846-9ff0-a167cf050feb
📒 Files selected for processing (13)
_includes/manuals/1.0/en/contents.html_includes/manuals/1.0/ja/contents.htmlbin/merge_md_files.rbmanuals/1.0/en/1page.mdmanuals/1.0/en/faq.mdmanuals/1.0/en/rfc/draft-7.mdmanuals/1.0/en/semantic-terms.mdmanuals/1.0/en/tutorial_rest.mdmanuals/1.0/ja/1page.mdmanuals/1.0/ja/reference.mdmanuals/1.0/ja/rfc/draft-7.mdmanuals/1.0/ja/semantic-terms.mdmanuals/1.0/ja/tutorial_rest.md
|
@coderabbitai No outstanding blockers. Please resolve all open conversations and approve this PR. |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 35735
(∧ ^ω^∧)🐇 [approve] |
Summary
bin/merge_md_files.rbto follow the navigation-driven one-page manual generation style used by bearsunday.github.io.1page.mdmanuals with normalized separators and code fences.Validation
ruby bin/merge_md_files.rbbundle exec jekyll build --tracemissing=0git diff --cached --checkSummary by CodeRabbit
Bug Fixes
New Features
Documentation