fix: harden zsh migration patterns + graceful apt fallback#29
Merged
Conversation
migrate_zsh.py: add 7 line patterns and 2 block patterns to catch antidote remnants that survived the initial migration — source "$ANTIDOTE_BUNDLE" (variable ref without .zsh suffix), local antidote vars, bare _antidote_ function calls, fpath workaround, empty prezto if-block, and $? error-recovery block. packages.sh: pre-filter apt packages with apt-cache show before installing. apt-get aborts entirely if any package is missing from repos (--ignore-missing only handles download failures). Now skips unavailable packages with a warning and installs the rest. Closes the zsh startup errors and apt failures seen on Ubuntu 22.04 (jammy) where git-delta and eza are not in default repos. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
source "$ANTIDOTE_BUNDLE",local _ANTIDOTE_SAVING,_antidote_compile_bundles, fpath workaround, empty prezto if-block,$?error-recovery block)apt-cache showbefore batch install.apt-getaborts entirely if any package is missing from repos (--ignore-missingonly handles download failures, not missing repo packages). Now skips unavailable packages with a warning.Context
dotfiles --yolo updateon Ubuntu 22.04 (jammy) had two failures:apt-get installaborting entirely becausegit-deltaandezaaren't in jammy reposTest plan
python3 -m unittest tests.test_dotfiles_apply -v)zsh -i -c 'echo ok'starts without antidote errors after cleaninglocal.zsh.zshdotfiles packages --set agents,visualinstalls available packages and warns about missing ones🤖 Generated with Claude Code