feat: support --yolo in subcommand position for update and install#25
Merged
Conversation
Previously `dotfiles update --yolo` silently ignored the flag because --yolo was only parsed in the global option loop. Users naturally type the flag after the subcommand, matching how --fast and --skip-tools already work in both positions. Add --yolo case arms to run_update() and run_install() argument parsers, update the update help text, and add four new tests covering subcommand-position usage and flag-combination overrides. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dotfiles update --yoloanddotfiles install --yolonow work (previously the flag was silently ignored in subcommand position)--skip-applyand--skip-toolsare already recognized in both global and subcommand parsersexportstatements for yolo variables in bothrun_update()andrun_install()dotfiles update --helpto document the--yoloflagTest plan
dotfiles install --yolo --dry-runshows "ALL agent tools" + "ALL packages"dotfiles update --yolo --dry-runshows "ALL agent tools" + "ALL packages"dotfiles --yolo update --dry-runstill works (regression)--fast/--skip-toolscorrectly override--yolotool installation--skip-applycorrectly overrides--yoloapply stepdotfiles update --helpshows--yoloflagpytest tests/test_dotfiles_bin.py -v)🤖 Generated with Claude Code