Turn math cache into its own object#897
Open
xmariachi wants to merge 4 commits into
Open
Conversation
spooktheducks
requested changes
Jan 7, 2026
spooktheducks
left a comment
Contributor
There was a problem hiding this comment.
Per comments in private messages with @jmdkastro and @xmariachi , I say we hold on approvals here pending:
- solid benchmarking showing that this cache is actually necessary (as opposed to just causing code bloat)
- a more performantly constructed key for the cache map (we can reduce
Decimalinto hashable bytes much more efficiently than converting to string withfmt.Sprintf) - an understanding as to why we're fragmenting the cache, which somewhat negates the effects of caching math in the first place
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of Changes and their Description
Turning math cache into an object instead of using global vars.
Are these changes tested and documented?
Unreleasedsection ofCHANGELOG.md?