Skip to content

chore(ci): cleanup CI system#518

Merged
albttx merged 3 commits into
mainfrom
fixes/ci
Apr 17, 2026
Merged

chore(ci): cleanup CI system#518
albttx merged 3 commits into
mainfrom
fixes/ci

Conversation

@albttx
Copy link
Copy Markdown
Member

@albttx albttx commented Mar 31, 2026

No description provided.

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 31, 2026

Deploy Preview for dither-staging ready!

Name Link
🔨 Latest commit f3b3597
🔍 Latest deploy log https://app.netlify.com/projects/dither-staging/deploys/69e24bbb2a3e2100083aa77c
😎 Deploy Preview https://deploy-preview-518--dither-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Comment thread .github/workflows/docker.yml Outdated
@jeronimoalbi
Copy link
Copy Markdown
Member

Why are the mainnet-reader-main.yml, mainnet-api-main.yml and the similar "testnet" ones deleted?

@albttx
Copy link
Copy Markdown
Member Author

albttx commented Apr 17, 2026

Why are the mainnet-reader-main.yml, mainnet-api-main.yml and the similar "testnet" ones deleted?

These workflows were deleted because they were redundant. The docker.yml workflow already handles everything they did, but in a simpler, unified way:

Before (old setup):

  • mainnet-api-main.yml → pushed to GCP on api/v* tags
  • mainnet-reader-main.yml → pushed to GCP on reader/v* tags
  • testnet-api-main.yml → pushed to GCP on every push to main
  • testnet-reader-main.yml → pushed to GCP on every push to main

After (simplified):

  • docker.yml → builds both api-main and reader-main, pushes to GHCR:
    • On push to main → tagged as latest
    • On v* tags → tagged with the version (e.g., v1.2.3)

The key changes:

  1. Single workflow instead of 4 separate ones
  2. Single tag format (v*) instead of separate api/v*, reader/v* tags
  3. GHCR (GitHub Container Registry) instead of GCP Artifact Registry — no need for GCloud auth secrets

@jeronimoalbi
Copy link
Copy Markdown
Member

Related to #513

@albttx albttx merged commit 26880fb into main Apr 17, 2026
10 checks passed
@albttx albttx deleted the fixes/ci branch April 17, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready to Build

Development

Successfully merging this pull request may close these issues.

2 participants