Add call recording playback URLs#13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
LiveKit stores completed recordings as S3 object keys such as
Voice-agents/Recordings/<id>.ogg. The console was passing that raw key into<audio src>, so even after recording upload works, the browser would not have a playable URL.This change makes
GET /callsandGET /calls/:idreturn a presigned playback URL for any stored S3 recording key. Existing null values and already-signed/absolute URLs are left unchanged.Validation
pnpm --filter server exec tsx --test tests/calllogs/calllog.service.test.tspnpm --filter server check-typespnpm --filter server buildpnpm --filter console exec eslint src/components/calls/AudioPlayer.tsxpnpm --filter console buildgit diff --checkNotes
pnpm --filter console lintstill fails on an unrelated existing error inapps/console/src/hooks/queries/mcp.ts(prefer-constforintervalId). The changedAudioPlayerfile passes targeted lint.S3_BUCKET_NAMEto the server container.