[codex] Fix ZeptoMail auth email sending#11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetchcall.SMTP_HOST=smtp.zeptomail.invalue, while also supporting explicitZEPTOMAIL_URL/ZEPTOMAIL_TOKENenv vars.Why
The ECS task crash was caused by the ZeptoMail SDK throwing
TypeError: resp.json is not a functionafter an auth email path attempted to send mail. The service itself recovered, but this made email-triggered requests capable of crashing thequickvoice-servercontainer. Calling the ZeptoMail REST API directly gives us predictable error handling and avoids the SDK failure path.Production env note
No mandatory AWS production env change is required for this PR if
SMTP_HOST=smtp.zeptomail.inandSMTP_PASSWORDis already the ZeptoMail Send Mail/API token. Optional cleanup later: add explicitZEPTOMAIL_URL=api.zeptomail.inand/orZEPTOMAIL_TOKENfor clarity.Validation
node --import tsx --test apps/server/tests/*.test.ts apps/server/tests/**/*.test.ts