feat: Claude Code 작업 환경 검증용 404 페이지 이스터에그 게임 구현#353
Conversation
|
🚀 Preview Deployment
|
/review 결과변경 파일 (벤치마크:
절대 규칙
보조 점검
다음 단계
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9bc39f3dd7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| # remote 와 비교가 안 되는 경우 (첫 push 등) 최근 커밋 기준 | ||
| RANGE=$(git rev-list @{u}..HEAD 2>/dev/null | head -1) | ||
| if [ -z "$RANGE" ]; then | ||
| CHANGED_FILES=$(git diff --name-only HEAD~5..HEAD 2>/dev/null || git diff --name-only HEAD) |
There was a problem hiding this comment.
Don't skip first-push builds on short branches
When a developer pushes a new branch with no upstream and fewer than five commits, HEAD~5..HEAD fails and the fallback git diff --name-only HEAD only compares the working tree against HEAD; on a clean push that yields no changed files, so client/admin source changes are treated as absent and the pre-push build is skipped. This defeats the hook in the exact “first push” case described by the comment; use a valid base such as the merge-base with the target branch or git diff-tree --name-only over the pushed commits instead.
Useful? React with 👍 / 👎.
위험
중간
낮음
|




작업 내용
올클 404 페이지에 Chrome dino 오마주 미니 점프 게임 추가:
변경 사항 및 리뷰 포인트
리뷰 포인트:
useJumpGame훅 안의 ref 다수 사용 — 게임 루프(raf)가 매 프레임 mutate 해야 하는 값이라 state 대신 ref. React 외부에서 state 추적하는 패턴.useCallback메모 대신handleActionRef로 stale closure 회피. 마운트 1회만 등록.<button>사용 (JumpGame.tsx:105) — 디자인 시스템Button대신. pixel-art 톤 일관성 +pointer-events-auto커스텀 필요..claude/rules/allcll-ui.md의 "단발성 화면 전용 raw element" 케이스.SPEED_INITIAL=2.5,JUMP_VELOCITY=8,GRAVITY=0.5, 캐릭터 36×36, 장애물 최대 32×32. 가장 빡빡한 케이스 마진 ~12% 확보,SPEED_MAX=6까지 가속해도 클리어 가능.