chore: CI 트리거 브랜치 패턴 확장#331
Conversation
feature branch 대상 자식 PR에서도 CI가 동작하도록 branches 패턴에 feat/**, fix/**, refactor/** 추가 Closes #330 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: af94bc04fc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| dependencies { | ||
| implementation 'org.springframework.boot:spring-boot-starter-data-jpa' | ||
| implementation 'org.springframework.boot:spring-boot-starter-web' | ||
| implementation 'org.springframework.boot:spring-boot-starter-security' |
There was a problem hiding this comment.
Adding spring-boot-starter-security here enables Spring Boot's default web security for the whole application; I checked the repo for SecurityFilterChain, @EnableWebSecurity, authorizeHttpRequests, and permitAll and found no security configuration to reopen the existing public /api/** controllers. In a deployed app this will turn unauthenticated requests into 401/login challenges, including endpoints like /api/subjects, /api/notices, and /api/connect, which is unrelated to the CI trigger change and would break clients unless a matching security config is added.
Useful? React with 👍 / 👎.
Removed spring-boot-starter-security dependency.
chemistryx
force-pushed
the
chore/ci-branch-pattern
branch
2 times, most recently
from
3d99176 to
80d9906
Compare
1 participant
Summary
pull_request.yml의 branches를["main"]에서["main", "feat/**", "fix/**", "refactor/**"]로 확장Test plan
Closes #330
Generated with Claude Code