Conversation
Contributor
|
7210777 can also close #6. However, in #14 @Huoyuan100861 argues that the fix might affect the correctness of the generated tree node results. |
Contributor
Author
|
@Huoyuan100861 Could you provide some information about the validation? #14 |
Collaborator
|
Well Done! @WWeiOne |
zyksir
approved these changes
May 30, 2025
AndreaRaffaelli
pushed a commit
to AndreaRaffaelli/SimAI
that referenced
this pull request
Oct 21, 2025
* [Fix] network_frontend ns3 integer overflow * [Fix] double free
gallomassimo
pushed a commit
to NetMeasurements-Team/SimAI
that referenced
this pull request
Dec 8, 2025
* [Fix] network_frontend ns3 integer overflow * [Fix] double free
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue #117 will trigger double free #89, which usually occurs in large topologies and workloads
double free or corruption (!prev)double free or corruption (out)previous commit based on #127