feat(k8s): update cr update to opt pool controller perf #99
Conversation
Spground
requested review from
Generalwin,
fengcone and
kevinlynx
as code owners
Spground
force-pushed
the
feature/public-opt-pool-sche-perf
branch
from
71c7ec3 to
1873e4d
Compare
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1873e4d2e3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| body = self.create_pool_manifest(self.total_bsb_count * self.replicas_per_bsb) | ||
| self.custom_api.create_namespaced_custom_object(GROUP, VERSION, NAMESPACE, POOL_PLURAL, body) |
There was a problem hiding this comment.
The pool size CLI option is ignored: setup_pool always builds the Pool manifest using self.total_bsb_count * self.replicas_per_bsb, so passing --pool-size has no effect on the created pool capacity. This can invalidate perf results when callers expect a larger/smaller pool; the script should use the user-supplied pool size (or remove the flag).
Useful? React with 👍 / 👎.
| await asyncio.sleep(0.5) | ||
| if time.time() - start_polling > 120: # 2 minutes timeout | ||
| print(f"⏰ Timeout waiting for {name}") |
There was a problem hiding this comment.
The --timeout argument is parsed and printed but never applied; allocation polling always stops after a hardcoded 120s. This means users cannot extend or shorten the timeout for slow/fast clusters, which can skew success rates or make runs unexpectedly long.
Useful? React with 👍 / 👎.
2 participants
Summary
Opt pool controller perf by avoid write conflicts.
Testing
Breaking Changes
Checklist