sdp: Always use ActPass when sending an offer#893
Open
bekriebel wants to merge 1 commit intoalgesten:mainfrom
Open
sdp: Always use ActPass when sending an offer#893bekriebel wants to merge 1 commit intoalgesten:mainfrom
bekriebel wants to merge 1 commit intoalgesten:mainfrom
Conversation
Per RFC 8842 Section 5.2/5.5: Offerers MUST always use a=setup:actpass. Answers use the the negotiated DTLS role. Previously, offers were also using the negotiated role.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I was investigating a different issue, I came across this discrepancy. I don't have a real-world issue that this is affecting, but I wanted to open the PR in case you want to align with the RFC.
The text from the RFC: