Better lifting for grevlex GBs over QQ#266
Open
mohabsafey wants to merge 5 commits intoalgebraic-solving:masterfrom
Open
Better lifting for grevlex GBs over QQ#266mohabsafey wants to merge 5 commits intoalgebraic-solving:masterfrom
mohabsafey wants to merge 5 commits intoalgebraic-solving:masterfrom
Conversation
jerebertho
approved these changes
Feb 23, 2026
Contributor
jerebertho
left a comment
jerebertho
left a comment
There was a problem hiding this comment.
Besides these small space issues, this looks good to me.
Thanks!
| if(!(nprimes & (nprimes - 1))){ | ||
| fprintf(stdout, "{%d}", nprimes); | ||
| fflush(stdout); | ||
| fflush(stdout); |
Contributor
There was a problem hiding this comment.
Suggested change
| fflush(stdout); | |
| fflush(stdout); |
space issue
| if(info_level){ | ||
| fprintf(stdout, "<%.2f%%>", 100* (float)MIN((dlift->lstart + 1), (*modgbsp)->ld)/(*modgbsp)->ld); | ||
| fflush(stdout); | ||
| fflush(stdout); |
Contributor
There was a problem hiding this comment.
Suggested change
| fflush(stdout); | |
| fflush(stdout); |
space issue
Contributor
There was a problem hiding this comment.
There are a few more space issues, but otherwise I am also fine with this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a result, this new code saves a significant amount of memory for computing GBs over QQ (by factors increasing with the size of problems ; sometimes more than 3 times).
Issue #258 seems fixed also.
The export functions have also been tested through Julia / AlgebraicSolving.jl under ubuntu