-
-
Notifications
You must be signed in to change notification settings - Fork 46
Add vagrant #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add vagrant #69
Conversation
|
Hey @antrew, thanks for your PR! Looks interesting – what's the difference to Docker? Not sure the Vagrant setup is shorter than the Setup Guide tbh – it appears to be the same length as for one OS and requires technical background to pull off. The length of the Setup Guide is mainly owned to being geared towards technically unexperienced users, thus being very verbose. BR, Alfons |
|
Hey @alfonsrv, you are right, the setup steps have probably about the same complexity for a non-technical user as the other setup options. I see Vagrant as an additional option that might have benefits for some users. Here are some pros that I could come up with:
Btw, thanks a lot for this project! I'm still |
|
I have tried out the Docker setup and find it very good. 👍 The proposed Vagrant setup has only some minor improvements compared to the existing Docker setup:
I'm also totally fine with closing this Pull Request, if you don't find it useful. Btw, thanks again for impf-botpy, I just got my apppointments. 🙇 |
|
Hey @antrew, nah not at all – more options if they're useful are always appreciated. Did you book your appointment over Vagrant? Even though the points you outlined are mostly (and correct me if I'm wrong) the same benefits of Docker, the Docker-based image has issues with creating reproducible results compared to a full-on Desktop – the main issue not being but being shadow-banned quite frequently when running in a Docker-container. Not sure what's wrong here, but the deployed bot detection seems to somehow be able to pick up on it (might have something to do with the locales, but not sure) Therefore I'd be happy to deprecate Docker in favor of a more exotic variant – in this case being Vagrant. BR, Alfons |
|
Hey @alfonsrv, yes, I booked my appointment in Vagrant with Chromium instead of Chrome (as in the Pull Request), with these settings:
Remote booking via Telegram was crucial for me, because otherwise I never managed to enter my data fast enough. Even when I submitted the form within couple minutes after the notification, the appointment was not there anymore ("Der ausgewählte Termin ist nicht mehr verfügbar."). With remote booking via a Telegram message it worked on the second or third attempt. With regard to shadow ban: there are some "Attempting to recover from shadow ban by waiting until" messages in my log, but most of the time the bot just keeps "Rechecking for new appointments". With regard to Docker: I don't think that shadow ban happens more often in Docker, it is probably just a coincidence. Technically there is no way to tell if the browser runs in Docker, in Vagrant or natively - it's the same browser running on Debian Buster on x86 hardware. As far as I know (not 100% sure though), Webdriver starts a clean browser every time (cookies, local storage, etc). Probably there is some fingerprinting on the server side, but my guess would be that there are just too many people trying to get an appointment these days. I would not deprecate Docker in favor of Vagrant, but rather have both to give users more choice. I'll have a look into the Docker setup, maybe I can simplify it, or add XFCE4 there to have a better user experience. Other than that the Docker setup is pretty neat. NoVNC was a good surprise! 👍 I did not expect to be able to use the GUI in Docker setup without having to install and configure a VNC tool, but it turned out that a browser was all I needed. |
I have noticed that the instructions for setting up all the dependencies are pretty lengthy. I am a big fan of Vagrant and have used it in many projects to ease the setup. Hope this would be useful for impf-botpy.