Add AssertTrueInsteadOfDedicatedAssertOperation (java:S5785)#160
Merged
Conversation
Implements SonarQube rule java:S5785 "JUnit assertTrue/assertFalse should be simplified to its dedicated assertion". Mirrors the SonarJava detection logic: - assertTrue(a == null) → assertNull(a) - assertTrue(a != null) → assertNotNull(a) - assertTrue(a == b) [prim] → assertEquals(a, b) - assertTrue(a != b) [prim] → assertNotEquals(a, b) - assertTrue(a == b) [obj] → assertSame(a, b) - assertTrue(a != b) [obj] → assertNotSame(a, b) - assertTrue(a.equals(b)) → assertEquals(a, b) - assertTrue(Objects.equals(a,b)) → assertEquals(a, b) - assertTrue(!expr) → complement of assertTrue(expr) - assertFalse(...) → complement of the above Supports JUnit 4 (org.junit.Assert, junit.framework.Assert/TestCase) and JUnit 5 (org.junit.jupiter.api.Assertions), with message argument preserved in its original position (first for JUnit 4, last for JUnit 5). Static wildcard imports are handled without any additional import management. Four test cases: JUnit 4 qualified calls, JUnit 5 qualified calls (via .txt source file), wildcard static imports, and noop cases. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements SonarQube rule java:S5785 "JUnit assertTrue/assertFalse should be simplified to its dedicated assertion". Mirrors the SonarJava detection logic:
Supports JUnit 4 (org.junit.Assert, junit.framework.Assert/TestCase) and JUnit 5 (org.junit.jupiter.api.Assertions), with message argument preserved in its original position (first for JUnit 4, last for JUnit 5). Static wildcard imports are handled without any additional import management.
Four test cases: JUnit 4 qualified calls, JUnit 5 qualified calls (via .txt source file), wildcard static imports, and noop cases.