Add ModifiersOrderOperation (java:S1124)#159
Merged
Merged
Conversation
Implements SonarQube rule java:S1124 — modifiers must appear in the JLS canonical order (public/protected/private, abstract, default, static, final, transient, volatile, synchronized, native, strictfp). Visits every BodyDeclaration node, extracts keyword modifiers, sorts them by the canonical index, and uses ASTRewrite ListRewrite to replace each out-of-order modifier in-place, leaving annotations at their original positions. Mirrors SonarJava's ModifiersOrderCheck detection logic (iterate through modifiers against the canonical enum order; report first violation). Tests cover: static/public swap on methods, final/static and final/public/static on fields, synchronized/static, native/static, volatile/transient, nested-class abstract/static/public reordering, and nested method reordering. Noop cases confirm already-correct orderings and single-modifier declarations are untouched. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements SonarQube rule java:S1124 — modifiers must appear in the JLS canonical order (public/protected/private, abstract, default, static, final, transient, volatile, synchronized, native, strictfp).
Visits every BodyDeclaration node, extracts keyword modifiers, sorts them by the canonical index, and uses ASTRewrite ListRewrite to replace each out-of-order modifier in-place, leaving annotations at their original positions.
Mirrors SonarJava's ModifiersOrderCheck detection logic (iterate through modifiers against the canonical enum order; report first violation).
Tests cover: static/public swap on methods, final/static and final/public/static on fields, synchronized/static, native/static, volatile/transient, nested-class abstract/static/public reordering, and nested method reordering. Noop cases confirm already-correct orderings and single-modifier declarations are untouched.