Preserve trailing comments on kept imports in UnusedImportRefactor#154
Merged
Merged
Conversation
Unused imports are always removed, including those with trailing same-line comments (e.g. // NOPMD, // NOSONAR). Used imports that carry a trailing comment have their comment preserved through the sort: the verbatim source text is emitted via a string placeholder on re-insertion. Implementation notes: - CompilationUnitProperty.SOURCE stores the original source text on the compilation unit so comment text can be extracted by position without file I/O. - Comment detection scans the remainder of the import's line in the source string for a '//' prefix (getCommentList() is not populated in standalone ASTParser mode). - run() returns early for non-top-level-type nodes to avoid re-processing the import list on subsequent visitor callbacks for inner classes etc. Adds ImportWithTrailingCommentExample / ...After golden-file test and a corresponding test method in TestImportsRefactor. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unused imports are always removed, including those with trailing same-line comments (e.g. // NOPMD, // NOSONAR). Used imports that carry a trailing comment have their comment preserved through the sort: the verbatim source text is emitted via a string placeholder on re-insertion.
Implementation notes:
Adds ImportWithTrailingCommentExample / ...After golden-file test and a corresponding test method in TestImportsRefactor.