Make rlm subcalls parallel with thread safety and semaphore#136
Open
h4shk4t wants to merge 7 commits into
Open
Make rlm subcalls parallel with thread safety and semaphore#136h4shk4t wants to merge 7 commits into
h4shk4t wants to merge 7 commits into
Conversation
Owner
|
I'll look at this when I get time, this is pretty important to get in IMO (assuming it's correct) |
…wd race, default=1 - Remove global subcall semaphore and related API (set_global_max_subcalls, etc.) per maintainer feedback — concurrency bounded by ThreadPoolExecutor(max_workers) only - Fix _temp_cwd race condition: restore to self.original_cwd instead of os.getcwd() which could point to a deleted temp dir under concurrent execution ([Errno 2]) - Change default max_concurrent_subcalls from 4 to 1 (sequential, backward-compatible) - Scope max_concurrent_subcalls env_kwargs pass to local environment only - Append pending_llm_calls in prompt order for deterministic metadata - Remove duplicate semaphore-dependent tests, fix default assertions (4→1) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Made-with: Cursor
6b60ec9 to
dbb701f
Compare
Owner
|
Fix linting issues first, otherwise lgtm! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds parallel execution support for rlm_query_batched, allowing child RLM subcalls to run concurrently instead of sequentially. This provides significant speedup when the parent model fans out multiple independent queries (e.g., answering 3 independent questions simultaneously).
Changes
rlm/core/rlm.pyrlm/environments/local_repl.pytests/test_rlm_query.pyDesign decisions
Usage