Skip to content
This repository was archived by the owner on Sep 1, 2025. It is now read-only.

Bookmarks#7

Open
BlueGreenMagick wants to merge 5 commits into
alexwlchan:masterfrom
BlueGreenMagick:bookmarks
Open

Bookmarks#7
BlueGreenMagick wants to merge 5 commits into
alexwlchan:masterfrom
BlueGreenMagick:bookmarks

Conversation

@BlueGreenMagick

@BlueGreenMagick BlueGreenMagick commented Jan 22, 2020

Copy link
Copy Markdown

Add bookmark_users to Work.

Work.bookmark_users returns a list of (list of usernames) and (list of pseudonyms) in case people needed to know both. ex: [ [user1, user2, ,user3], [pseuds1, pseuds2, pseuds3] ]

On additional note, it also saves session in Work.__init__ so it can be reused when getting bookmarked users.

@BlueGreenMagick

Copy link
Copy Markdown
Author

When testing on a fiction with 2000+ bookmarks, came across an issue of server responding with Retry Later message instead. Should I add a time delay between requests? Or I could add the delay on Retry Later response.

@alexwlchan alexwlchan left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch! I haven't used this code in a while so my knowledge is a bit foggy.

I’ve put a couple of comments inline. I’m happy to pick up the patch and finish it off, or if you’d rather go back and forth until it’s in a mergeable state, that works too.

Comment thread src/ao3/works.py
Comment thread src/ao3/works.py Outdated
Comment thread src/ao3/works.py Outdated
Comment thread src/ao3/works.py
Comment thread src/ao3/works.py
standard library.

bookmark_users is not provided
due to time it takes to go through all the bookmarks

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it provided above?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first line of comment says that complete representation of work is provided when calling json(). But because of bookmark_users not being provided when calling json(), it is no longer a complete representation, which was the reason I wrote that line.

Perhaps it should be reworded differently?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants