Bookmarks#7
Conversation
|
When testing on a fiction with 2000+ bookmarks, came across an issue of server responding with |
alexwlchan
left a comment
There was a problem hiding this comment.
Thanks for the patch! I haven't used this code in a while so my knowledge is a bit foggy.
I’ve put a couple of comments inline. I’m happy to pick up the patch and finish it off, or if you’d rather go back and forth until it’s in a mergeable state, that works too.
| standard library. | ||
|
|
||
| bookmark_users is not provided | ||
| due to time it takes to go through all the bookmarks |
There was a problem hiding this comment.
The first line of comment says that complete representation of work is provided when calling json(). But because of bookmark_users not being provided when calling json(), it is no longer a complete representation, which was the reason I wrote that line.
Perhaps it should be reworded differently?
Add bookmark_users to Work.
Work.bookmark_usersreturns a list of (list of usernames) and (list of pseudonyms) in case people needed to know both. ex:[ [user1, user2, ,user3], [pseuds1, pseuds2, pseuds3] ]On additional note, it also saves session in
Work.__init__so it can be reused when getting bookmarked users.