This repository was archived by the owner on Sep 1, 2025. It is now read-only.
don't login if password is not passed to User#6
Open
BlueGreenMagick wants to merge 2 commits into
Open
Conversation
Owner
|
Thanks for these patches! I’m glad somebody is finding the code useful. 😄 I’m travelling the next few days, so I won’t have time to look at them properly until sometime next week. |
Owner
|
What sort of user information are you retrieving without login? Bookmarks? It’s not obvious to me what you need to get if not logged in. |
Author
|
It could be used to get other users' info - their works and bookmarks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since user information can be retrieved without login, there should be an option to not attempt login