Weather fixes#84
Open
jedahan wants to merge 3 commits into
Open
Conversation
Collaborator
Author
|
Renamed from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The api_key we distribute is out of date, and our calls use 'N/E/S/W' instead of "+/-" in lat/lon
Figure step 1 would be to read from local.json, and we can import secrets management in another PR that will cleanup .spenv stuff.
Eventually, probably wanna switch from openweathermap because there current product is deprecated, and they have no apis that are non-subscription based.
I can share my api_key in the group chat for testing