Skip to content

fix(column): guard negative/oversized SQL_LEN in BindableColumn.Value #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SAY-5 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(column): guard negative/oversized SQL_LEN in BindableColumn.Value #225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion column.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,15 @@ func (c *BindableColumn) Value(h api.SQLHSTMT, idx int) (driver.Value, error) {
if !c.IsVariableWidth && int(c.Len) != c.Size {
return nil, fmt.Errorf("wrong column #%d length %d returned, %d expected", idx, c.Len, c.Size)
}
return c.BaseColumn.Value(c.Buffer[:c.Len])
// Guard against drivers (seen with DB2 on CHAR columns with UTF-8
// DSN encoding) that return a negative SQL_LEN or one larger than
// the bound buffer. The old code sliced c.Buffer[:c.Len] directly
// and panicked with 'slice bounds out of range [:-4]'.
n := int(c.Len)
if n < 0 || n > len(c.Buffer) {
return nil, fmt.Errorf("column #%d returned length %d out of range for buffer size %d", idx, c.Len, len(c.Buffer))
}
return c.BaseColumn.Value(c.Buffer[:n])
}

// NonBindableColumn provide access to columns, that can't be bound.
Expand Down