Parallax bookscreen#43
Open
KorrAn34 wants to merge 20 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR combines new features from dynamic rendering and what is suggested by the title (sorry about that I did not realise that this would be the case until late into the process)
In addition to the previous isolated PR, this one includes parallax scrolling on the thavmonomicon homepage, blinking of unknown and available research entries (their widgets), cropping of entry widgets so that they do not render outside the box, and improved rendering logic so that research entries with children and with nonzero coordinates do not crash the game.
EntryScreen.kt now also contains a val scale: Int which can be changed manually to adjust the font size in research entry titles, paragraphs and figure captions. Additionally, I converted the tentative Thavma entries to the previously pull-requested dynamic rendering form.