Fix database locked error during concurrent access#16
Merged
Conversation
alecgard
force-pushed
the
fix/db-locked-concurrent-access
branch
from
7b53549 to
10b081a
Compare
Added schemaReady() read-only check to initSchema so read-only operations (sources list, query, export) skip all writes when the schema is already initialized. This prevents SQLITE_BUSY errors when these commands run during ingestion. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
alecgard
force-pushed
the
fix/db-locked-concurrent-access
branch
from
10b081a to
17a2945
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #12.
kb sources list(and other read-only commands) failed withdatabase is lockedwhen run during ingestion, becauseinitSchemaunconditionally ran write statements even when the schema was already set up.Added a
schemaReady()read-only check — a single SELECT on the metadata table. If the schema is already initialized with the correct embedding dimension, all writes are skipped entirely.Changes
internal/store/sqlite.go— AddedschemaReady()fast path ininitSchemainternal/store/sqlite_test.go— AddedTestConcurrentOpenDuringWriteTest plan
make testpasseskb ingeston a large repo, simultaneously runkb sources list🤖 Generated with Claude Code