Extracted validation rules to enable use without ActiveModel#3
Open
dvrensk wants to merge 20 commits into
Open
Extracted validation rules to enable use without ActiveModel#3dvrensk wants to merge 20 commits into
dvrensk wants to merge 20 commits into
Conversation
valid DNI if it does not even have the form of a DNI, etc
returning booleans
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a large pull request, but I hope you enjoy it. It fixes a number of non-obvious bugs (see commits tagged "Bug fix:" and possibly others) and makes it possible to use the validations outside of ActiveModel. It is also quite a large refactoring of both tests and implementation to improve readability (which is how I discovered some of the bugs) by revealing intent and making all the cases clear.
I have taken care to make each commit readable in itself, so that it should be easy to see that I don't lose any test cases or functionality along the way. Some of the commits might seem pointless but I can argue for each and every one of them.
I have updated the README except for the history section, and I haven't changed the version number. If I may be so bold, I would suggest that you make the next release v1.0 since I believe that this code is now ready for production and general release (with the caveat that I haven't looked at the JS at all).