Skip to content

[WIP] quantized tensor#39

Draft
ashari4 wants to merge 3 commits into
albanD:mainfrom
ashari4:ashari/quantized_tensor
Draft

[WIP] quantized tensor#39
ashari4 wants to merge 3 commits into
albanD:mainfrom
ashari4:ashari/quantized_tensor

Conversation

@ashari4

@ashari4 ashari4 commented Jun 5, 2022

Copy link
Copy Markdown

@albanD

albanD commented Jun 6, 2022

Copy link
Copy Markdown
Owner

Hi!

This looks really interesting. I think there is some small changes that you can make to simplify this and avoid saving the data twice. I added a commit in this branch: https://github.com/albanD/subclass_zoo/tree/quantized_tensor_alban (feel free to steal that and add it to your branch if you want it).

Also the autograd handling is still not super clear to me but I think the idea should be that the wrapper tensor should have the high precision dtype (and so the autograd engine will be happy with it) but the raw_data can be whatever dtype you want it to be (low precision or high precision depending on what you need).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants