feat(sdk): ArrayBuffer DataChannel support and dual-channel sync#46
Merged
Conversation
Optimize native binary receive, honor binaryType in SDK, add voicethere-sync helpers, binary examples (roundtrip + mesh), and browser-cosine-chat game sync. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bytesinto NodeBufferon receive (one copy when uniquely owned)binaryType: 'arraybuffer', passBufferthrough on send, e2e binary round-trip testvoicethere-syncchannel,sendBinaryToClient,onDataChannelBinarygame-state-syncshared module,start:binary/start:binary-mesh, browser-cosine-chat canvas syncRelease note (proposed 0.5.4)
Publish
@node-webrtc-rust/bindings,sdk,signaling,helperstogether first — downstream repos depend on helpers sync channel + native binary path.Verified locally:
run-pr-quality.sh,build:native,build:ts, SDK e2e,start:binary,start:binary-mesh.