Skip to content

Potential fix for code scanning alert no. 12: Unsafe shell command constructed from library input #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
akabarki76 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Potential fix for code scanning alert no. 12: Unsafe shell command constructed from library input #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/core/src/tools/shell.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import {
isCommandAllowed,
stripShellWrapper,
} from '../utils/shell-utils.js';
import * as shellQuote from 'shell-quote';

export const OUTPUT_UPDATE_INTERVAL_MS = 1000;

Expand Down Expand Up @@ -205,7 +206,7 @@ export class ShellTool extends BaseTool<ShellToolParams, ToolResult> {
? strippedCommand
: (() => {
// wrap command to append subprocess pids (via pgrep) to temporary file
let command = strippedCommand.trim();
let command = shellQuote.quote([strippedCommand.trim()]);
if (!command.endsWith('&')) command += ';';
return `{ ${command} }; __code=$?; pgrep -g 0 >${tempFilePath} 2>&1; exit $__code;`;
})();
Expand Down
Loading