feat: upgrade Android SDK to 3.2.1, fix critical bugs, add Expo plugin#3
Closed
ajitpatel028 wants to merge 1 commit intoajitpatel28:mainfrom
Closed
Conversation
…g plugin - Migrate to ActivityResultLauncher, fix dark mode mid-session, fix setLocale ordering - Fix isSdkUsable returning Promise treated as boolean, add missing error event listeners - Add clearTruecallerSdk, consentMode, sdkOptions support - Add Expo config plugin for automatic AndroidManifest.xml setup
ajitpatel28
force-pushed
the
feature/android-truecaler-sdk-upgrade
branch
from
8a46a38 to
a819c7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade Truecaller Android SDK to 3.2.1 + Expo config plugin
Summary
onActivityResultwithActivityResultLauncher/ActivityResultRegistryisSdkUsable()— was returning aPromiseobject (always truthy) instead of the actual booleansetLocaleordering — moved to afterTcSdk.init()TruecallerAndroidErrorandTruecallerAndroidVerificationRequiredclearTruecallerSdk()for manual SDK cleanupandroidConsentModeandandroidSdkOptionsconfig optionsapp.plugin.js) for automaticAndroidManifest.xmlsetuptypesfield topackage.jsonfor older TypeScript consumersBreaking Changes
isSdkUsable()now returnsPromise<boolean>— callers mustawaititTest plan
isSdkUsable()returns correct boolean (not alwaystrue)androidDarkModeis not setclearTruecallerSdk()cleans up without crashapp.plugin.jsinjectsClientIdmeta-data correctlyexpo prebuilddoes not duplicateClientIdentry