Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
mimetype엔트리는 항상 압축하지 않고 먼저 기록해야 하는 규칙을 명확히 반영하기 위해 변경했습니다.compress_type이 기대값대로 설정되는지 자동으로 검증할 필요가 있었습니다.Description
HwpxPackage._save_to_zip의 직접 쓰기 로직을_write_archive로 분리하여mimetype를 먼저 기록하도록 변경했습니다._write_zip_entry헬퍼로 공통화했고,_write_mimetype는 이 헬퍼를 사용해mimetype를ZIP_STORED로 기록하도록 했습니다._write_zip_entry(..., ZIP_DEFLATED)로 기록하도록 유지했습니다.tests/test_opc_package.py에 저장된 ZIP 엔트리의compress_type을 검사하는test_save_preserves_expected_compress_type_per_entry테스트를 추가했습니다.Testing
pytest -q tests/test_opc_package.py를 실행해 변경된 테스트를 포함한 스위트를 실행했습니다.3 passed, 1 warning으로 모든 테스트가 통과했습니다.Codex Task