Skip to content

Conversation

@halka
Copy link

@halka halka commented Jan 21, 2026

format required.

@halka
Copy link
Author

halka commented Jan 21, 2026

ref. #45
Format required and check structure.

@halka halka changed the title update Hakodate RJCH;s RDR(APP/DEP) update Hakodate RJCH's RDR(APP/DEP) Jan 21, 2026
@makrsmark
Copy link
Contributor

can this stay as 1-line?
json/airport-frequencies-pretty.json is the formatted file

respond PR's comment.
@coderabbitai
Copy link

coderabbitai bot commented Jan 22, 2026

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

💤 Files selected but had no reviewable changes (2)
  • json/airport-frequencies-pretty.json
  • json/airport-frequencies.json

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@halka
Copy link
Author

halka commented Jan 22, 2026

@makrsmark

can this stay as 1-line? json/airport-frequencies-pretty.json is the formatted file

OK, responded. plz check. If it is ok, also plz merge to main.

@makrsmark
Copy link
Contributor

makrsmark commented Jan 22, 2026

@halka can you update json/airport-frequencies-pretty.json as well? I will merge then.

@halka
Copy link
Author

halka commented Jan 22, 2026

@makrsmark Sure! I did.

@makrsmark
Copy link
Contributor

@halka can you shrink the pretty diff? it looks like you rearraged the order of the attributes for everything

example:
before

      {
         "description" : "CTAF",
         "frequency" : "122.9",
         "ident" : "00CA",
         "ourairports_airport_id" : "6528",
         "ourairports_id" : "70518",
         "type" : "CTAF"
      },

after

    {
      "ourairports_id": "70518",
      "ourairports_airport_id": "6528",
      "ident": "00CA",
      "type": "CTAF",
      "description": "CTAF",
      "frequency": "122.9"
    },

I would prefer before as all the attributes are in alphabetical order

@makrsmark
Copy link
Contributor

looks like the compact version is the same thing. I can't really verify you only changed RJCH

@halka
Copy link
Author

halka commented Jan 22, 2026

@makrsmark Thank you for checking.
I'm proceeding. pretty and compact files.

@halka
Copy link
Author

halka commented Jan 22, 2026

@makrsmark Thanks for the comment in #45 (comment)
Regarding Hakodate Airport, the actual controlling Shirakami Approach (RDR) is for both arrivals and departures.
I’ve updated the frequency data on OurAirports accordingly, but the PR'ed file still shows APP and DEP separately.
Note that the logic already accounts for potential gaps in ourairports_id.
What would be the best way to handle this discrepancy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants