-
-
Notifications
You must be signed in to change notification settings - Fork 12
update Hakodate RJCH's RDR(APP/DEP) #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
format required.
|
ref. #45 |
|
can this stay as 1-line? |
respond PR's comment.
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (2)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
OK, responded. plz check. If it is ok, also plz merge to main. |
|
@halka can you update |
|
@makrsmark Sure! I did. |
|
@halka can you shrink the pretty diff? it looks like you rearraged the order of the attributes for everything example: after I would prefer before as all the attributes are in alphabetical order |
|
looks like the compact version is the same thing. I can't really verify you only changed RJCH |
|
@makrsmark Thank you for checking. |
|
@makrsmark Thanks for the comment in #45 (comment) |
format required.