Skip to content

make ListInfo and variants public.#199

Merged
pohmelie merged 2 commits into
aio-libs:masterfrom
sakosha:public-list-infos
Sep 24, 2025
Merged

make ListInfo and variants public.#199
pohmelie merged 2 commits into
aio-libs:masterfrom
sakosha:public-list-infos

Conversation

@sakosha
Copy link
Copy Markdown
Contributor

@sakosha sakosha commented Sep 23, 2025

What do these changes do?

Include BasicListInfo, ListInfo and UnixListInfo to aioftp.client.__all__.

Reasoning

PyCharm & VSCode intellisense add squiggle lines on imports like from aioftp.client import UnixListInfo.

Are there changes in behavior for the user?

Evil usages such as enumerating on __all__ and asserting length will break.

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.94%. Comparing base (253546a) to head (cf5dbf8).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #199   +/-   ##
=======================================
  Coverage   97.94%   97.94%           
=======================================
  Files           6        6           
  Lines        2093     2093           
=======================================
  Hits         2050     2050           
  Misses         43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/aioftp/client.py
@pohmelie pohmelie merged commit a271817 into aio-libs:master Sep 24, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants