Add optimize_last_step_only to coupled LossContributionsConfig#868
Open
Add optimize_last_step_only to coupled LossContributionsConfig#868
optimize_last_step_only to coupled LossContributionsConfig#868Conversation
jpdunc23
changed the base branch from
main
to
coupled-ft-with-stochastic-atmos
1 task
…ce into feature/coupled-optimize-last-step-only
…ce into feature/coupled-optimize-last-step-only
…ce into feature/coupled-optimize-last-step-only
…ce into feature/coupled-optimize-last-step-only
…ce into feature/coupled-optimize-last-step-only
…optimize-last-step-only
…optimize-last-step-only
…mize-last-step-only
jpdunc23
commented
Apr 9, 2026
Comment on lines
+1669
to
+1673
| optimize = self._loss.step_is_optimized( | ||
| "atmosphere", | ||
| global_atmos_step, | ||
| n_total_atmos_steps, | ||
| ) |
Member
Author
There was a problem hiding this comment.
This was previously handled in CoupledStepper.get_prediction_generator() but refactored to be handled here in CoupledTrainStepper._accumulate_loss().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
optimize_last_step_onlyboolean tofme.coupled'sLossContributionsConfigto allow for optimization of the final output step's loss while ignoring earlier steps. This can be configured independently for the atmosphere and ocean components of the coupled stepper.Changes:
Refactored
CoupledStepper.get_prediction_generator()to remove thestep_is_optimizedargument to reduce coupling between theCoupledStepperandCoupledTrainStepperConfig, sincestep_is_optimizedis aCoupledStepperTrainLossconcern.Tests added