Draft
Conversation
brianhenn
reviewed
Apr 3, 2026
Contributor
brianhenn
left a comment
brianhenn
left a comment
There was a problem hiding this comment.
Looks good, some minor suggestions
| Parameters: | ||
| method: Type of fill operation. Currently only 'constant' is supported. | ||
| value: Value to fill NaNs with. | ||
| zonal_interp_variables: Variables to fill via periodic zonal (longitude) |
Contributor
There was a problem hiding this comment.
If this is getting merged it seems like we'd want to add 'zonal_interp` as a method in addition to 'constant' rather than adding a new arg
| x = np.arange(flat.shape[-1]) | ||
| for i in range(flat.shape[0]): | ||
| row = flat[i] | ||
| mask = np.isnan(row) |
Contributor
There was a problem hiding this comment.
This method is greedy, where does this fall in the call stack relative to where we actually load the tensors? I guess not actually wrong to load data earlier, but a bit confusing in terms of the data model
| right = array[..., :pad_width] | ||
| padded = np.concatenate([left, array, right], axis=-1) | ||
|
|
||
| orig_shape = padded.shape |
Contributor
There was a problem hiding this comment.
Nit use a different name than "orig" here since it has padding on it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of why the PR is needed and how it satisfies those requirements, in sentence form.
Changes:
symbol (e.g.
fme.core.my_function) or script and concise description of changes or added featureCan group multiple related symbols on a single bullet
Tests added
If dependencies changed, "deps only" image rebuilt and "latest_deps_only_image.txt" file updated
Resolves # (delete if none)