Span Buffer Multiprocess Enhancement with Health Monitoring#10
Open
akshayutture-augment wants to merge 1 commit into
Open
Span Buffer Multiprocess Enhancement with Health Monitoring#10akshayutture-augment wants to merge 1 commit into
akshayutture-augment wants to merge 1 commit into
Conversation
Author
|
cursor review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test 6
Replicated from ai-code-review-evaluation/sentry-cursor#6
Note
Introduce a multiprocess span flusher with per-process health monitoring and a new CLI option to cap flusher processes; wire through factory, enhance metrics/backpressure handling, and update tests.
SpanFlusherto manage multiple processes mapped to shard sets, with per-process buffers and restart logic (_ensure_processes_alive).process_healthy_since/process_backpressure_since; enforce backpressure across processes; aggregate Redis memory checks over all buffers; improved join/terminate behavior.sentry_spans_buffer_shards.ProcessSpansStrategyFactoryacceptsflusher_processesand passesmax_processestoSpanFlusher.--flusher-processestoprocess-spansconsumer insentry/consumers/__init__.py.test_flusher_processes_limit.CLAUDE.md: Add Python anti-pattern guidance to useisinstance()overhasattr()for unions.Written by Cursor Bugbot for commit 9bf83b0. Configure here.