Add comprehensive email validation for blocked users#8
Open
akshayutture-augment wants to merge 1 commit into
Open
Add comprehensive email validation for blocked users#8akshayutture-augment wants to merge 1 commit into
akshayutture-augment wants to merge 1 commit into
Conversation
… many times each email address is blocked, and last time it was blocked. Move email validation out of User model and into EmailValidator. Signup form remembers which email addresses have failed and shows validation error on email field.
Author
|
cursor review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test 3
Replicated from ai-code-review-evaluation/discourse-cursor#3
Note
Adds server-side blocked email validation with whitelist/blacklist support, updates signup to return structured errors, and prevents reusing rejected emails client-side.
EmailValidatorapplyingSiteSettingwhitelist/blacklist and newBlockedEmail.should_block?check;Usernow usesvalidates :email, email: true.BlockedEmailmodel (tracksmatch_count,last_match_at,action_type) with migrationcreate_blocked_emails.UsersController#createnow returnserrorsandvaluesin JSON on failure.user.email.blockedmessage.CreateAccountController: tracksrejectedEmailsto invalidate previously failedaccountEmail;emailValidationobservesrejectedEmails.EmailValidatorandBlockedEmail, plusblocked_emailfabricator.Written by Cursor Bugbot for commit 5f8a130. Configure here.