Async import of the appStore packages#10
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| if (bookingRef.uid) { | ||
| if (bookingRef.type.endsWith("_calendar")) { | ||
| const calendar = getCalendar(credentialsMap.get(bookingRef.type)); | ||
| const calendar = await getCalendar(credentialsMap.get(bookingRef.type)); |
There was a problem hiding this comment.
Bug: Async forEach: Unfinished Business
Using forEach with an async callback doesn't wait for promises to complete. The calendar deletion operations will be initiated but not awaited, causing the try-catch block to exit before operations finish and potentially leaving calendar events undeleted.
| if (bookingRef.uid) { | ||
| if (bookingRef.type.endsWith("_calendar")) { | ||
| const calendar = getCalendar(credentialsMap.get(bookingRef.type)); | ||
| const calendar = await getCalendar(credentialsMap.get(bookingRef.type)); |
There was a problem hiding this comment.
Bug: Async forEach: Unfinished Business
Using forEach with an async callback doesn't wait for promises to complete. The calendar deletion operations will be initiated but not awaited, causing the try-catch block to exit before operations finish and potentially leaving calendar events undeleted.
| .filter((credential) => credential.type.endsWith("_calendar")) | ||
| .forEach(async (credential) => { | ||
| const calendar = getCalendar(credential); | ||
| const calendar = await getCalendar(credential); |
There was a problem hiding this comment.
Bug: Unawaited Async Operations Leave Data Incomplete
Using forEach with an async callback doesn't wait for promises to complete. The calendar deletion operations for recurring events will be initiated but not awaited, potentially leaving calendar events undeleted when cancelling recurring bookings.
| if (bookingRef.uid) { | ||
| if (bookingRef.type.endsWith("_calendar")) { | ||
| const calendar = getCalendar(credentialsMap.get(bookingRef.type)); | ||
| const calendar = await getCalendar(credentialsMap.get(bookingRef.type)); |
There was a problem hiding this comment.
Bug: Async forEach leaves operations unawaited.
Using forEach with an async callback doesn't wait for promises to complete. The calendar and video deletion operations will be initiated but not awaited, potentially leaving integrations in an inconsistent state when requesting a reschedule.
2 participants
Test 2
Replicated from ai-code-review-evaluation/cal.com-cursor#2
Note
Cursor Bugbot is generating a summary for commit e043a5e. Configure here.