chore(deps-dev): bump @storybook/addon-essentials from 6.2.9 to 8.1.11#4
Conversation
Bumps [@storybook/addon-essentials](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/essentials) from 6.2.9 to 8.1.11. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/v8.1.11/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v8.1.11/code/addons/essentials) --- updated-dependencies: - dependency-name: "@storybook/addon-essentials" dependency-version: 8.1.11 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
|
@claude review this PR |
|
Claude finished @akshayutture-augment's task —— View job Code Review: Storybook Dependency UpdateI've reviewed this dependency update and identified several critical concerns that need to be addressed before merging. 🚨 Critical Issues1. Major Version Jump with Incompatible DependenciesThis PR updates only package.json:141 shows the inconsistency: "@storybook/addon-a11y": "^6.2.9",
"@storybook/addon-actions": "^6.2.9",
"@storybook/addon-essentials": "^8.1.11", // ← Only this was updated
"@storybook/addon-storysource": "^6.2.9",
"@storybook/addons": "^6.2.9",
"@storybook/builder-webpack5": "^6.2.9",
"@storybook/react": "^6.2.9",
"@storybook/theming": "^6.2.9"Impact: This creates a severe version mismatch. Storybook v8 is not designed to work with v6 packages, and this will likely cause:
2. Breaking Changes Between v6 → v8Storybook 8 introduces significant breaking changes from version 6:
.storybook/main.js:20-31 contains an Emotion 10→11 workaround that may no longer be compatible with Storybook 8's architecture. 📋 Required ActionsThis PR should NOT be merged as-is. Instead, one of these approaches is needed: Option A: Update All Storybook Packages (Recommended)Update all Storybook packages to v8.x together:
Then run the Storybook migration tool: npx storybook@latest upgradeOption B: Revert This ChangeKeep all Storybook packages at 6.2.9 until a coordinated upgrade can be planned. 🧪 Testing RequirementsIf proceeding with a full Storybook v8 upgrade, the following must be tested:
📊 Risk Assessment
💡 Recommendation❌ DO NOT MERGE this PR in its current state. Next Steps:
The security benefits and improvements in Storybook 8 are valuable, but they require a coordinated upgrade of the entire Storybook ecosystem, not just one addon. |
Bumps @storybook/addon-essentials from 6.2.9 to 8.1.11.
Changelog
Sourced from
@storybook/addon-essentials's changelog.... (truncated)
Commits
958e86cBump version from "8.1.10" to "8.1.11" [skip ci]3fda293Bump version from "8.1.9" to "8.1.10" [skip ci]01bb58eBump version from "8.1.8" to "8.1.9" [skip ci]001c9d8Bump version from "8.1.7" to "8.1.8" [skip ci]cc49ca8Bump version from "8.1.6" to "8.1.7" [skip ci]27a643dBump version from "8.1.5" to "8.1.6" [skip ci]9b706ffBump version from "8.1.4" to "8.1.5" [skip ci]d972793Bump version from "8.1.3" to "8.1.4" [skip ci]a2b9d08Bump version from "8.1.2" to "8.1.3" [skip ci]487b028Bump version from "8.1.1" to "8.1.2" [skip ci]You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)