FEATURE: per-topic unsubscribe option in emails#9
Open
akshayutture-augment wants to merge 1 commit into
Open
Conversation
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| return redirect_to @topic_view.topic.unsubscribe_url, status: 301 | ||
| end | ||
|
|
||
| tu = TopicUser.find_by(user_id: current_user.id, topic_id: params[:topic_id]) |
There was a problem hiding this comment.
tu can be nil for users without an existing TopicUser row on this topic, and tu.notification_level can also be nil; dereferencing or comparing it (nil > Integer) will raise. Consider guarding for a missing record and a nil notification_level before toggling.
🤖 Was this useful? React with 👍 or 👎
| @@ -1,31 +1,29 @@ | |||
| <div id='main' class=<%= classes %>> | |||
There was a problem hiding this comment.
The class attribute is missing quotes around <%= classes %>, which can produce invalid HTML when multiple classes are present and break styling in many email clients. Consider wrapping the value in quotes.
🤖 Was this useful? React with 👍 or 👎
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.